search

alexreisner / geocoder

Complete Ruby geocoding solution.
http://www.rubygeocoder.com
MIT License
6.35k stars 1.19k forks source link

[docs] add known issues about near scope #1639

Closed takatea closed 10 months ago

takatea commented 11 months ago

Thank you for your fantastic gem!

I met errors or a performance degradation when I tried to use Rails's pluck or select with the near scope of geocoder. Finally, I found the solution with select option of near scope, but unfortunately it is not documented well in the README. So, this PR adds descriptions for such cases.

By the way, I have some ideas to make select option more friendly for Rails users. I will open issues for them.

alexreisner commented 11 months ago

Thanks for this. It's very helpful. However, it's a lot of additional information, and I'm trying to keep the README as short as possible (it's already too long). Do you think we can get rid of the new sections and limit any additions to 10 lines? The problem is explained well enough on line 735, so I don't think we need the SQL examples. The most important things are the workarounds: the :select option on the near method and to_a.pluck. What if we just added the workarounds?

takatea commented 11 months ago

@alexreisner

Thanks for your review! I did not realise the section you mentioned. I agree to keep the README simple, and I will update this PR based on your feedback!

takatea commented 11 months ago

Hi, @alexreisner !

I fixed the document based on your suggestion, but it exceeds the 10-line limit slightly. It seems we can remove the known issue related to includes (line774-792) . What do you think?

Please review, and let me know if any adjustments are needed! Thanks in advance.

takatea commented 10 months ago

@alexreisner

Hi there! I pushed changes based on your feedback. Could you review this updated PR?

alexreisner commented 10 months ago

Hi! Sorry, I lost track of this. It looks great. Thank you!