alexrhowe / APOLLO

Atmosphere retrieval code for exoplanets
4 stars 1 forks source link

Pull out as much of the parametrization of cloud opacities out of the C++ side #83

Closed adadams closed 2 years ago

adadams commented 2 years ago

The goal here is to allow for more efficient development and use of different cloud models.

Roughly speaking, for any cloud model the C++ side ultimately needs to have a set of asymmetry parameters (g, or "cosbar"), single-scattering albedos (w0), and cross-sections as a function of wavelength and pressure. Currently I believe g and w0 work on the wavelength axis, and cross-sections fold into overall opacity as a function of pressure.

I think it would be more adaptable if we could assemble the g(lambda), w0(lambda), and cross-section(lambda, logP) arrays and just pass those on to the C++ side. Mainly because I'm better at parametrizing in Python. But this depends on whether there are any non-pre-computed cloud routines that would be significantly slower in Python; I think since the scattering tables are pre-computed, this shouldn't be too big an issue.

alexrhowe commented 2 years ago

Redundant with Issue #88.