Replace print statements with logger throughout

alexrkaufman / pytla

A library for controlling OIF ITLA MSA 1.3 based devices.

MIT License

8 stars 3 forks source link

Replace print statements with logger throughout #6

Open alexrkaufman opened 2 months ago

alexrkaufman commented 2 months ago

Based on feedback from @f3fora in https://github.com/alexrkaufman/pytla/pull/4.

Print statements exist in the following classes.

[x] itla12.py
[x] itla13.py
[ ] pplaser.py

I am not well versed in the logging and would happily take any advice for best practices in implementation.

alexrkaufman commented 2 months ago

The Pure Photonics laser has a function called cleanjump_calibration. This was set up to use some back and forth user input to confirm they had the clean jump frequencies configured correctly, and that the cleanjump frequencies were written down somewhere. These could be recorded in the logs instead so they're still accessible.

We may want to note some method for people to get access to the log information.

initial implementation f9a4119, maybe this would work?