search

alexrothenberg / ammeter

A gem that allows for you to write specs for your Rails 3 generators
MIT License
89 stars 28 forks source link

Rails 6 support? #61

Closed mjankowski closed 3 years ago

mjankowski commented 5 years ago

Not sure if this gem is still maintained, but FYI:

This line - https://github.com/alexrothenberg/ammeter/blob/master/lib/ammeter/rspec/generator/matchers/have_correct_syntax.rb#L33

Has an issue with Rails 6 because that method now expects two params - https://github.com/rails/rails/blob/master/actionview/lib/action_view/template/handlers.rb#L48

I believe the fix here is to provide an empty struct as first param and the source code as second, but am not familiar enough to be confident.

voxik commented 4 years ago

I think your analysis is correct. I put together the #62 to fix this issue.