search

alexrothenberg / motion-addressbook

MIT License
89 stars 30 forks source link

retire abhack.m #44

Closed jmay closed 10 years ago

jmay commented 11 years ago

See history in #22.

Release notes for RM 2.8 include this

  * Fixed a bug where Time#{==, eql?} would return the wrong value when using
    duplicated object from #copy.

If this fixes RM-81 then the abhack code can be retired.

alexrothenberg commented 11 years ago

We should test this & remove the abhack. I propose we add a version check like BubbleWrap does

# lib/motion-addressbook.rb
if Motion::Version < 2.8
  raise <<-MSG
MotionAddressBook requires RubyMotion version at least 2.8. If you cannot upgrade RubyMotion please use an older version of this gem 
"gem 'motion-addressbook', '<= 1.5.0'"
MSG
end
jmay commented 11 years ago

I just verified the fix with 2.8 and it seems to work. Such a relief. Patch coming shortly. I'll definitely put in the version check.

On 17 Sep, 2013, at 8:12 AM, Alex Rothenberg notifications@github.com wrote:

We should test this & remove the abhack. I propose we add a version check like BubbleWrap does

lib/motion-addressbook.rb

if Motion::Version < 2.8 raise <<-MSG MotionAddressBook requires RubyMotion version at least 2.8. If you cannot upgrade RubyMotion please use an older version of this gem "gem 'motion-addressbook', '<= 1.5.0'" MSG end — Reply to this email directly or view it on GitHub.