Closed colinta closed 11 years ago
Thanks for this it looks nice. I'd just like to add some tests for it before merging.
Also a style question: is there any reason you made the main methods class methods but the delegate is an instance?
any reason you made the main methods class methods but the delegate is an instance
Hm, I didn't consider making those delegate methods class methods, I suppose it would work. No particular reason, though.
I started to write tests, but figured we could get to it before merging, like you said. I don't know when I'll be able to come back and do that. I'm fighting a heck of a deadline right now...
I took a pass at refactoring the class and it seems to work when I test manually but I can't figure out how to write specs for it.
The cleanest way I could figure out how to do this in github was to create a branch on my repo with your and my changes.
https://github.com/alexrothenberg/motion-addressbook/tree/colinta-pull-6
WDYT?
neat. I just now noticed the "WDYT" note. I think it sounds good! :-)
I just pushed v0.1.2 with this.
Thanks again for adding this.
As much fun as that class is to type... ;-)
person
will benil
or an instance ofAddressBook::Person
Uses the
AddressBook::Picker
class, which stores a singleton reference to itself and assigns itself as a delegate to an instance ofABPeoplePickerNavigationController
.