search

alexrothenberg / motion-addressbook

MIT License
89 stars 30 forks source link

Remove bubblewrap as a dependency #76

Closed markrickert closed 9 years ago

markrickert commented 9 years ago
  1. Required all files and frameworks without bubble wrap
  2. Removed all instances of App. and Device. and converted them to their non-bubblewrap counterparts
  3. Converted app App.notification_center to use NSNotificationCenter counterparts.

Specs are still failing on my machine on iOS 8 but they're the exact same failures as on master

Closes #74

I'd suggest testing this heavily before merging. :beers:

jamonholmgren commented 9 years ago

@markrickert We're going to test this on a new app. If it works well, then we should get @alexrothenberg to merge it. Maybe he'd be willing to transfer ownership of motion-addressbook to IR or CS to continue development.

markrickert commented 9 years ago

Or perhaps the rubymotion community account?

jamonholmgren commented 9 years ago

That would work too.

alexrothenberg commented 9 years ago

Thank you both.

Sadly I am not spending much time on rubymotion right now but would be happy to add you as git collaborators & gem owners and/or move the official repo to the rm community account

jamonholmgren commented 9 years ago

:+1: for RubyMotion community account.

alexrothenberg commented 9 years ago

fyi the tests on travis have always failed due to the simulator asking the user for permission to access the addressbook. If you do that locally once the tests should pass after that but I never figured out how to do that with applescript on travis.

markrickert commented 9 years ago

Current master branch fails with 90 specifications (194 requirements), 4 failures, 3 errors

This branch locally fails with 90 specifications (194 requirements), 4 failures, 3 errors

Looks like we might be good to go so long as @jamonholmgren's test work out ok.

jamonholmgren commented 9 years ago

@kevinvangelder is currently working with it. He can update here.