search

alexrothenberg / motion-addressbook

MIT License
89 stars 30 forks source link

AddressBook/Contacts Redux #84

Open jbender opened 8 years ago

jbender commented 8 years ago

Lots going on here, this is basically a ground-up rewrite (drops all non-iOS support) with an emphasis on parity between the AddressBook and Contacts frameworks. Missing a lot of things at the moment, but thought I'd open this up here if someone else wants to chip in.

May be more appropriate to create another gem, but would prefer to keep from fragmenting too much.

alexrothenberg commented 8 years ago

This is amazing @jbender

I'm not doing much rubymotion at this point so sadly I'm not in a position to help move this forward but I'm really happy you're jumping in. I will add you as a collaborator here and on rubygems and can also put a pointer in the readme if you decide to carry on in a different repo.

Thank you for what's obviously a ton of work!

ankurgera commented 8 years ago

@jbender It seems you have merge conflicts with your PR. Kindly resolve them.

ankurgera commented 8 years ago

@jbender Also. Travis CI is throwing error's for your different commits. Kindly look into it.

ankurgera commented 8 years ago

@jbender Any luck on the PR conflicts resolution?

jbender commented 8 years ago

@ankurgera I haven't looked into this at all, but may have time later next week. The code is open source so feel free to manually resolve them or reference my version of the gem in your Gemfile in the interim

ankurgera commented 8 years ago

@jbender Thanks.

jbender commented 8 years ago

@ankurgera I'm sorry but I don't work for you. Do not make demands of my time; if you need a fix you're welcome to make the changes as the code is freely available, otherwise I'll get to it when convenient for me.

ankurgera commented 8 years ago

@jbender I am extremely sorry if you felt that way.

alexrothenberg commented 8 years ago

@ankurgera please be respectful of @jbender's time and his desire to carry this forward (or not). He was kind enough to offer this code contribution which looks like a lot of work that I totally appreciate. Its up to him whether he wants to wants to merge and maintain it and how much time he wants to contribute to this project - I'm sure he has other important things going on in his life.

As I mentioned I need to step back from this project and am happy if either or both of you want to carry this project forward but also understand that maintaining a project takes time and energy you may or may not have. Whatever you decide I appreciate that you've found what I did useful and offered your contributions. You're both free to carry this repo forward and/or create a fork and continue from there. Thank you!

ankurgera commented 8 years ago

@alexrothenberg I am extremely sorry. Honestly, I was really respectful of his time. I just got excited when he said that he may work on it by next week. He can take his own time, I have no problem at all. I will manage the solution by myself.

@jbender I am really really sorry. Honestly speaking, I had no intention of disrespecting your time. No one works here for any one. Everyone here contributes. I really appreciate your contribution. I just got excited with your work.