fix: update uri to omit deployment ids for assistant and thread paths

alexrudall / ruby-openai

OpenAI API + Ruby! 🤖❤️ NEW: Assistant Vector Stores

MIT License

2.73k stars 321 forks source link

fix: update uri to omit deployment ids for assistant and thread paths #431

Open CarterBland opened 7 months ago

CarterBland commented 7 months ago

Summary: Solves Assistants Support for Azure's new API version 2024-02-15-preview #430

Tested in my own local application and the URI with the deployment id omitted unblocks the whole process from creating an assistant, thread, and message.

Solution: Support assistants API by removing the deployment id for certain paths

Example: https://custom-domain.openai.azure.com/openai/deployments/gpt-35-turbo/assistants to https://custom-domain.openai.azure.com/openai/assistants

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?

CarterBland commented 5 months ago

@alexrudall Any status on this?

alexrudall commented 5 months ago

@alexrudall Any status on this?

Thanks for patience, I need to get access to Azure OpenAI so I can test this & other Azure PRs - hope to within next week or 2

CarterBland commented 4 months ago

@alexrudall Any updates?

emilong commented 2 months ago

@alexrudall fwiw, I just tested this on both the API versions listed on the Azure page and confirmed this fix works as expected

nhorton commented 1 month ago

@alexrudall - if you want, we could donate a key to you for this testing if it is blocking you. We really need this merged.

alexrudall commented 1 month ago

Hi @nhorton, @emilong , @CarterBland, thanks for this PR & for your patience. I'm considering releasing a 'pro' version of ruby-openai that would allow me to prioritise testing & merging features like this before adding to the free version at a later date - similar to sidekiq-pro & graphql-pro. I would also offer ongoing support, and other improvements including performance enhancement. Would your use cases justify this? Likely cost $299/year or similar. Again, thank you for your patience and apologies that I haven't been able to prioritise this PR yet.

nhorton commented 1 month ago

Sure - we would be happy to do that.

alexrudall commented 1 month ago

Thanks a lot @nhorton! I'll try to put that together this week and respond here.