alexruiz / fest-assert-2.x

FEST Fluent Assertions 2.x
http://fest.easytesting.org
Apache License 2.0
402 stars 69 forks source link

rename Date assertions isWithinXXX to hasSameXXXAs #143

Open joel-costigliola opened 11 years ago

joel-costigliola commented 11 years ago

I was never comfortable with isWithinXXX assertions (event though it was my idea ...), reading them after a while, I find it confusing, if you write ...

assertThat(date).isWithinSecond(otherDate);

... then do you want to compare seconds field of dates only or dates to seconds precision (in our case it is second field comparison only).

I come up with a clearer name (I think) : hasSameXXXFieldAs

So instead of

assertThat(date).isWithinSecond(otherDate);

We would have

assertThat(date).hasSameSecondFieldAs(otherDate);