Closed deadlyhifi closed 9 years ago
I think I'd prefer a separate spacing variable list - I don't much like the two new variables given by default and I did very much like the previous way of working.
I definitely wouldn't go so far as having separate variables for margin and padding but, as I've done with my branch, I'd at least like to keep the $space
variable set.
Let's build these up on a per project basis as you add to the variables files with your own stuff.
On the project I'm working on now I've added to the variables file
// Spacing
$space: $base-spacing;
$space-double: $space *2;
$space-half: $space / 2;
$space-quart: $space / 4;
So I'm building everything from $base-spacing
, using the quicker syntax that I'm used to, for consistency with spacing applied by default on other elements - e.g. <p>
.
That's fine by me! I'm happy to stick that in.
On 14 Feb 2015, at 9:46 am, Tom de Bruin notifications@github.com wrote:
Let's build these up on a per project basis as you add to the variables files with your own stuff.
On the project I'm working on now I've added to the variables file
// Spacing $space: $base-spacing; $space-double: $space *2;
$space-half: $space / 2; $space-quart: $space / 4; So I'm building everything from $base-spacing, using the quicker syntax that I'm used to, for consistency with spacing applied by default on other elements - e.g.
.
— Reply to this email directly or view it on GitHub.
As mentioned in the other thread:
If we're to have further variables they should be in the overrides folder that you just append to variables when you've pulled it down from bitters. Called it variable-appends
?
Yeah, happy with the merge - nothing much in there other than, like you say, the visual grid amends.
I think it's a good idea to have the variable-appends
file, which is where we'll do our stuff, although I'm trying to think of a sexier name for it! Haha!
On 14 Feb 2015, at 9:53 am, Tom de Bruin notifications@github.com wrote:
As mentioned in the other thread:
If we're to have further variables they should be in the overrides folder that you just append to variables when you've pulled it down from bitters. Called it variable-appends?
— Reply to this email directly or view it on GitHub.
Once we've decided on these we should add them. The setup script will need to append this variable-appends
file to _variables.scss
using cat variable-appends.scss >> _variables.scss
. Then delete variable-appends.scss
.
We talked about having some basic spacing like we used to e.g.
$space: 1em;
.I just noticed in
_variables.scss
there'swhich equates to
1.5em
and0.75em
respectively by default. Thesmall-spacing
being applied to the bottom of<p>
by default.Are we to build our spacing on an app specific basis from these defaults or do you want a separate spacing variable list?