alexryd / homebridge-shelly-ng

Homebridge plugin for the next generation of Shelly devices
GNU General Public License v3.0
121 stars 44 forks source link

Added choice of cover type #41

Closed aessing closed 2 years ago

aessing commented 2 years ago

In issue #28 people ask for adding a Shelly in cover mode as window covering and not as windows. As I had the same requirement, I decided to contribute and make some changes to the project.

I tested this on Homebridge v1.5.0 on Nodejs v16.16.0 on Almalinux 9 and it worked for me as expected. It would be great if somebody else could do some more testing.

alexryd commented 2 years ago

Thanks for your PR @aessing, I really appreciate it. I'm not going to merge it though, for several reasons. Mostly because I'm about to release my own implementation of this config option, but also for a few other reasons:

Anyway, thanks again!