search

alexsanjoseph / compareDF

R Tool to compare two data.frames
Other
93 stars 17 forks source link

dplyr 0.8.1 compatibility #19

Closed romainfrancois closed 5 years ago

romainfrancois commented 5 years ago

I'm getting a failure as part of dplyr 0.8.1 reverse dependency checks: 


> library(testthat)
> library(compareDF)
> 
> test_check("compareDF")
── 1. Failure: (unknown) (@test-fnsComparison.R#74)  ───────────────────────────
output$change_count not equivalent to `expected_change_count`.
Incompatible type for column `changes`: x integer, y numeric

── 2. Failure: (unknown) (@test-fnsComparison.R#357)  ──────────────────────────
`expected_change_count` not equivalent to actual_comparison_summary$change_count.
Incompatible type for column `changes`: x numeric, y integer

══ testthat results  ═══════════════════════════════════════════════════════════
OK: 46 SKIPPED: 0 FAILED: 2
1. Failure: (unknown) (@test-fnsComparison.R#74) 
2. Failure: (unknown) (@test-fnsComparison.R#357) 

Error: testthat unit tests failed
Execution halted

I will look for details later, but in the meantime, perhaps it is something you can address.

alexsanjoseph commented 5 years ago

@romainfrancois - I've updated the package on CRAN. Does this solve the problem?