search

alexsanjoseph / compareDF

R Tool to compare two data.frames
Other
93 stars 17 forks source link

[create_output_table] color code bugs with xlsx export #29

Closed pamdx closed 4 years ago

pamdx commented 4 years ago

Hey guys,

Thanks a lot for this awesome package, it's helping me a lot in my work!

Just wanted to point out a bug I've been running into. For some reason, when I export my comparison table in Excel, the color code in the table becomes incoherent (as opposed to exporting in html, which creates tables with the expected color code).

More specifically, when cell values are replaced between the new and the old datasets, the xlsx export will show additions in red and removals in green.

Here's an example showing the difference in (1) xlsx and (2) html exports:

image

image

I'm using R version 3.6.1 (2019-07-05) and compareDF version 2.0.0

alexsanjoseph commented 4 years ago

This is a known bug. Can you try installing the development version? It will be fixed in the next CRAN update as well

On Tue, 14 Jan, 2020, 19:32 pamaudoux, notifications@github.com wrote:

Hey guys,

Thanks a lot for this awesome package, it's helping me a lot in my work!

Just wanted to point out a bug I've been running into. For some reason, when I export my comparison table in Excel, the color code in the table becomes incoherent (as opposed to exporting in html, which creates tables with the expected color code).

More specifically, when cell values are replaced between the new and the old datasets, the xlsx export will show additions in red and removals in green.

Here's an example showing the difference in (1) xlsx and (2) html exports:

[image: image] https://user-images.githubusercontent.com/59026485/72350199-3fd84880-36de-11ea-831a-6d84e4ba69c5.png

[image: image] https://user-images.githubusercontent.com/59026485/72350240-57afcc80-36de-11ea-8496-4329e2f117d5.png

I'm using R version 3.6.1 (2019-07-05) and compareDF version 2.0.0

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/alexsanjoseph/compareDF/issues/29?email_source=notifications&email_token=AAHLW5H2A3FZRFL6SLDJ2OTQ5XAYLA5CNFSM4KGTQXLKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IGCBTWQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHLW5H7DMLRJG7LOBQZNEDQ5XAYLANCNFSM4KGTQXLA .

pamdx commented 4 years ago

Ok great to hear, thanks for the quick answer!

alexsanjoseph commented 4 years ago

Keeping this open until the next cran release

alexsanjoseph commented 4 years ago

I've pushed the bugfix to CRAN. Closing issue