lcougnaud commented 4 years ago

I experienced the following error when importing the compareDF::compare_df package in my own package:

a <- data.frame(ref = letters[1:20],change = 1:2)
b <- data.frame(ref = letters[1:21],change = 1:3)
compare_df(df_new = a, df_old = b, group_col = "ref",  stop_on_error = TRUE)
Error in group_indices(.) : could not find function "group_indices"

This issue is solved if a new import is created for the dplyr::group_indices function in the group_columns function (see change in pull request).

codecov[bot] commented 4 years ago

Codecov Report

Merging #37 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files           2        2           
  Lines         235      235           
=======================================
  Hits          229      229           
  Misses          6        6

Impacted Files	Coverage Δ
R/fnsComparison.R	`98.71% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d1a2871...5f7406d. Read the comment docs.

alexsanjoseph commented 4 years ago

Hey @lcougnaud - Thanks for the PR - I think it looks good. Merging

alexsanjoseph / compareDF

add import dplyr group_indices #37

Codecov Report