search

alexsanjoseph / compareDF

R Tool to compare two data.frames
Other
93 stars 17 forks source link

[Simplify] No warning/error returned when two data frames are the same. #56

Open SophieSuSu opened 6 months ago

SophieSuSu commented 6 months ago

Is your feature request related to a problem? Please describe. I'm always concernd about the warning/error when the two same data frames supplied, which makes gaining a clean log file become challenging. For the purpose of validation, it‘s acceptable that df_new and df_old are the same and no need to return a warning/error.

Describe the solution you'd like I'd like to request that no warning/error returned when two data frames are the same. Instead a meesage is enough.

Describe alternatives you've considered Or to add flexible options for users to select which level is preferable.

Additional context The comparasion result of no change between two dataframe are also useful and differences can/must not always be detected.

alexsanjoseph commented 6 months ago

Why not just wrap this in a try catch and ignore?

SophieSuSu commented 6 months ago

Thank you for the resolution.