search

alexscheelmeyer / node-phantom

bridge to PhantomJS from Node.js
317 stars 117 forks source link

createPage does not callback #112

Open bengfarrell opened 10 years ago

bengfarrell commented 10 years ago

It used to be that my project using this node-phantom package worked. Now it doesn't. CreatePage now no longer calls back.

It would seem that the difference is that Socket.IO was updated past 1.0. If I force an npm install of socket.io 0.9.16, everything seems to work.

However, the package.json specifies >=0.9.6 and I end up with 1.0.6, which seems to have some issues with this project...mainly that I don't seem to be getting socket.on('res') messages.

onyxrev commented 10 years ago

+1

nicroto commented 10 years ago

+1 @bengfarrell This is the problem, indeed.

jmonster commented 10 years ago

yup: https://github.com/alexscheelmeyer/node-phantom/pull/104

nicroto commented 10 years ago

Guys, I am using shrinkwrap to lock the current versions.

Before running it, you should make sure that the supported version of socket.io (0.9.16 works for me) is installed in node_modules. Then run it to generate npm-shrinkwrap.json:

$ npm shrinkwrap --dev

When a team member downloads your repo, there is nothing extra she/he should do, just

$ npm install

But during development, you should regenerate the npm-shrinkwrap.json if you add/remove/update-to-new-version-of a module.

I hope this will be helpful for you.

txdv commented 10 years ago

@alexscheelmeyer Can we get this change into the npm package repository? It is really annoying to do it manually all the time.

marko-ciric commented 9 years ago

+1