Better handling of phantom crashes

alexscheelmeyer / node-phantom

bridge to PhantomJS from Node.js

317 stars 117 forks source link

Better handling of phantom crashes #55

Closed vmeurisse closed 11 years ago

vmeurisse commented 11 years ago

Previous code was checking for code !== 0 && signal === null. When phantomjs crash on my machine (debian testing, phantom 1.8.2), code is 0 and signal is SIGSEGV.

New code is more pragmatic. If phantom exit for any reason, we need to shutdown the server.

alexscheelmeyer commented 11 years ago

Thanks, have implemented this now in latest.