search

alexschimpf / fastapi-versionizer

FastAPI Versionizer
MIT License
81 stars 13 forks source link

Do you have any plans to support WebSocket API? #47

Closed spiritlessman closed 11 months ago

spiritlessman commented 11 months ago

Subject of the issue

Support versioning WebSocket API.

I just made up the 'pull request'(https://github.com/alexschimpf/fastapi-versionizer/pull/48). Could you review this?

Your environment

Steps to reproduce

Call Versionizer().versionize() after adding some WebSocketAPI routes.

Expected behaviour

WebSocket API should also be versioned.

Actual behaviour

All APIWebSocketRoute is removed after Versionizer().versionize().

alexschimpf commented 11 months ago

I commented on the PR. Just thinking we should probably add some test coverage for websockets.

alexschimpf commented 11 months ago

@spiritlessman This is now available in 3.0.4. Thanks for the work! I'm going to close this issue, but please open a new one if you see any other issues related to websockets.