fix: Missing WebSocket routes after versionizing is fixed

spiritlessman commented 10 months ago

Pull Request Checklist

[v] Make sure to read the contributor guide here.
[v] Make sure you are making a pull request against the main branch.
[v] Make sure your pull request title matches the requested format.
[v] Make sure to lint, type-check, and run unit and API tests.

Description

I found the bug that WebSocket routes are removed after calling versionize method. So, I fixed the bug and updated that WebSocket routes also are versionized. But I'm worry that causes side-effects. Could you review this revision?

alexschimpf commented 10 months ago

@spiritlessman Can you add a test so we have some kind of coverage for this?

spiritlessman commented 10 months ago

@spiritlessman Can you add a test so we have some kind of coverage for this?

I revised the commit to added example and test submodule for WebSocket.

alexschimpf commented 10 months ago

One minor test failure. Rest looks good to me.

alexschimpf commented 10 months ago

:tada: This PR is included in version 3.0.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

alexschimpf / fastapi-versionizer

fix: Missing WebSocket routes after versionizing is fixed #48

Pull Request Checklist

Description