alexschimpf / fastapi-versionizer

FastAPI Versionizer
MIT License
79 stars 13 forks source link

fix: Tests are not breaking anymore #54

Closed yuripiratello closed 6 months ago

yuripiratello commented 6 months ago

I the problem is when you define a root_path on FastAPI it's append the root_path to the openapi_url, but not to the docs page. This might be something from FastAPI structure, I tried to find the reason or when this changed but I couldn't find.

Pull Request Checklist

Description

The problem is when you define a root_path on FastAPI, it appends the root_path to the openapi_url, but not to the docs page. This might be something from the FastAPI structure. I tried to find out why or when this changed, but I couldn't find it.

alexschimpf commented 6 months ago

This still breaks for python 3.7 because the latest FastAPI version isn't supported for it. I'm kinda thinking we should stop supporting python 3.7 because FastAPI has dropped support for it as of 0.104.0.

alexschimpf commented 6 months ago

@yuripiratello I included this in my PR for dropping python 3.7 support. Thanks!