search

alexschneider / teascript

5 stars 2 forks source link

Display all errors, not just the last one, and throw exceptions instead of returning errors #53

Closed alexschneider closed 9 years ago

alexschneider commented 9 years ago

Close #49

rachelriv commented 9 years ago

Looks great so far! I'd feel more comfortable merging this once we have some tests for the error module itself. Do you think that you could please write a teascript program that would generate a parsing error and then check that the error that was generated is what we expect?

alexschneider commented 9 years ago

@rachelriv, Chai doesn't seem to be working, do you mind trying to fix it?

If I pass any invalid string, it fails appropriately, but if I pass a valid string, it times out. It makes no sense.

alexschneider commented 9 years ago

@rachelriv Should be fixed, please merge