search

alexschneider / teascript

5 stars 2 forks source link

Program2.tea isn't a valid program #68

Closed alexschneider closed 9 years ago

alexschneider commented 9 years ago

All functions should have an end at the end of them

https://github.com/alexschneider/teascript/blob/master/test/example/input_programs/valid_programs/program2.tea

Not necessary because it's testing the scanner, but it'd be nice if all our valid programs were valid programs.

rtoal commented 9 years ago

I would say it is necessary because the path name of this file does not include any indication that it is a scanner test. Therefore anyone looking at this file would think the file is valid teascript.

rachelriv commented 9 years ago

I just suggested to @whusted and @juansc that we have separate directories within the valid and invalid example program directions for the scanner, parser, etc. Then we might have the same program in the valid/scanner/ directory and the invalid/parser/ directory.

alexschneider commented 9 years ago

I think that might get too confusing - I'd rather all our valid programs be completely valid.

rachelriv commented 9 years ago

The tests have been refactored so that it is clear when a program is only valid for scanning, parsing, etc.