search

alexschwantes / node-red-contrib-htu21d-2

Node-RED node for HTU21D humidity sensors
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Please create a pull request #1

Open maxwellhadley opened 7 years ago

maxwellhadley commented 7 years ago

Please can you create a pull request against my original htu21d repo so we can keep in step. I'd much rather not proliferate contrib nodes that do nearly the same thing as there are already so many it gets difficult to manage.

Thanks

Max

alexschwantes commented 7 years ago

Hi Max, I was initially thinking to do that, but your plugin still works for older nodejs/node-red versions (I was using it before). However it just doesn't compile on the later versions. I haven't tested my changes to see if they work on previous versions so merging it with yours could potentially break the plugin for someone running on an older nodejs/node-red version...

maxwellhadley commented 7 years ago

Alex - that’s OK, you can specify an ‘engine’ dependency in package.json so npm will not try to install a newer version that won’t run on the version of nodeJS it finds. Node-RED is itself now limited to version 4 & above, I believe

Max

On 24 Jan 2017, at 10:22, alexschwantes notifications@github.com wrote:

Hi Max, I was initially thinking to do that, but your plugin still works for older nodejs/node-red versions (I was using it before). However it just doesn't compile on the later versions. I haven't tested my changes to see if they work on previous versions so merging it with yours could potentially break the plugin for someone running on an older nodejs/node-red version...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/alexschwantes/node-red-contrib-htu21d-2/issues/1#issuecomment-274764317, or mute the thread https://github.com/notifications/unsubscribe-auth/AGQOClxL9ddmCiwZQ8iwF5MOvBkqHQMlks5rVdECgaJpZM4LpLun.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/alexschwantes/node-red-contrib-htu21d-2","title":"alexschwantes/node-red-contrib-htu21d-2","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/alexschwantes/node-red-contrib-htu21d-2"}},"updates":{"snippets":[{"icon":"PERSON","message":"@alexschwantes in #1: Hi Max, I was initially thinking to do that, but your plugin still works for older nodejs/node-red versions (I was using it before). However it just doesn't compile on the later versions. I haven't tested my changes to see if they work on previous versions so merging it with yours could potentially break the plugin for someone running on an older nodejs/node-red version..."}],"action":{"name":"View Issue","url":"https://github.com/alexschwantes/node-red-contrib-htu21d-2/issues/1#issuecomment-274764317"}}}

alexschwantes commented 7 years ago

Thanks Max, I'll look into that. might take a little bit, am swamped right now though.