search

alexshyba / SitecoreSearchContrib

Extension to Sitecore.Search namespace. Includes AdvancedDatabaseCrawler and Searcher. Make sure to check out the website for the project.
http://sitecorian.github.io/SitecoreSearchContrib
25 stars 21 forks source link

Naming convention #11

Closed DotTech closed 11 years ago

DotTech commented 11 years ago

Why would you prefix your namespace with "sc" ? This will fail the naming convention for a lot of projects. It would be better if it's renamed to Sitecore.SearchContrib.*

Best regards,

Ruud van Falier ParTech IT, Netherlands

DotTech commented 11 years ago

This commit fixes this issue: 10459956a6294f5740893ad25c162f8797572d8e I understand this is a breaking change, so no worries if you decide not to use it. I just needed it fixed for my project so figured I'd share.

alexshyba commented 11 years ago

Mostly because TDS was ignoring the Sitecore prefixed dlls from being deployed and that used to not be configurable. Another reason is identity crisis and the desire to keep it short :-) My hope is to convert this to "supercharger" family, and address the namespace.

DotTech commented 11 years ago

Hehe, okay.. maybe rename it to the Sitecorian namespace then ;-) I'll keep my own version for now. Awesome work btw, loving this module!