alexsilva / supervisor

Supervisor process control system for Windows
http://supervisord.org
Other
119 stars 26 forks source link

Honoring stopasgroup / killasgroup defaulting to false #45

Open Flygsand opened 1 year ago

Flygsand commented 1 year ago

Thanks for this awesome port. Looking at the main Supervisor docs, stopasgroup and killasgroup default to false. But since this port puts child processes into a job without breakaway, they are in effect always true here if I'm not mistaken?

Related LimitFlags:

Use case: I have an app that spawns an updater process that stops the service and expects to be orphaned. The updater completes the update and the starts the service back up again. But due to the above, the updater gets terminated with the job and the service never restarts. Setting JOB_OBJECT_LIMIT_SILENT_BREAKAWAY_OK in process.py fixes this according to my expectations of stopasgroup and killasgroup.

alexsilva commented 1 year ago

I understand the problem and thank you for the detailed explanation. But due to lack of time a solution for this may take time. If you want, you can advance part of this work by sending a pull request with tests if possible.