alexsocha / luckyblock

The Lucky Block mod for Minecraft.
50 stars 21 forks source link

Lucky Bow doesn't have durability, and enchantments do not work on it (except for Infinity) #102

Open kristibektashi opened 1 year ago

kristibektashi commented 1 year ago

Environment

Describe the bug In the Fabric version of the mod, the Lucky Bow does not lose durability when used, unlike the Lucky Sword Steps to reproduce: Step 1: Give yourself a Lucky Bow Step 2: Give yourself arrows Step 3: Make sure you are in Survival mode Step 4: Shoot an arrow using the Lucky Bow Expected behavior: the Lucky Bow loses durability Observed behavior: the Lucky Bow does not lose durability

Also, the bow enchantments do not work properly on the Lucky Bow and although they can be applied, there is no visible difference compared to the Lucky Bow without enchantments. This is in contrast to the vanilla bow, where all enchantments work properly. Only exception to this is the Infinity enchantment, which works properly on the Lucky Bow

Example to reproduce: Step 1: Give yourself a vanilla bow (and arrows) Step 2: Enchant it with Punch 2 (via Anvil, Enchantment table or commands) Step 3: Shoot an entity Observed behavior: The entity gets knocked back several blocks

Step 4: Give yourself a Lucky Bow (and arrows) Step 5 (optional): Reduce it's luck to -100 to prevent it from spawning other projectiles in order to make testing easier Step 6: Enchant it with Punch 2 Step 7: Shoot an entity Expected behavior: The entity gets knocked back several blocks, just like with the vanilla bow Observed behavior: The entity gets knocked back less than 1 block The Power enchantment does not seem to increase damage dealt with Lucky Bow either, and Flame does not set entities on fire. Unbreaking and Mending cannot be tested as long as durability doesn't exist on the Lucky Bow. However, Infinity properly works on the Lucky Bow and prevents arrows from being consumed.

Other mods that were active while I was testing: Identity mod, Architectury API, Optifabric, Optifine, Essential Client, FerriteCore, Phosphor, Replay Mod, Mod Menu. These probably don't affect anything but I thought it's worth mentioning that I have them

Note: This is for the Fabric version only. I have no idea if this happens with the Forge version or not.

Screenshots If applicable, add screenshots here.

Log file If applicable, add your log file here.