search

alexspeller / emblem-rails

Emblem.js integration with rails asset pipeline
MIT License
34 stars 21 forks source link

Handlebars 2.0 error #32

Open alexphys opened 9 years ago

alexphys commented 9 years ago

Updating in ember >= 1.9.0 beta 3 requires handlebars 2.0. Updating to latest emblem-source (3.17 or 3.18 that are supposed to support handlebars) doesn't seem to work with it. Im getting errors module is not defined in every .emblem file.

Eptis commented 9 years ago

Any progress on this?

MichaelSp commented 9 years ago

same here. Is there a workaround?

botandrose commented 9 years ago

I was able to get emblem-rails working with ember 1.9. The issue is not in this codebase, but in two other related repos: emblem-source and barber-emblem. emblem-source needed to be bumped to master, and barber-emblem needed to be pointed to a fork.

# Gemfile
gem "emblem-source", github: "machty/emblem.js"
gem "barber-emblem", github: "simcha/barber-emblem"

As an aside, it looks like machty is not able to support these gems anymore, and is looking for new maintainers.

alexspeller commented 9 years ago

Thanks @botandrose, I will add this to the readme

machty commented 9 years ago

@alexspeller @botandrose it should work with "machty/barber-emblem"; I merged simcha's PR and pushed 0.1.2 of barber-emblem

machty commented 9 years ago

Can this issue be closed with these latest pushes?

botandrose commented 9 years ago

Almost, not quite... need a new release of emblem-source too.