search

alexspeller / emblem-rails

Emblem.js integration with rails asset pipeline
MIT License
34 stars 21 forks source link

Update rubygems version #6

Closed dparis closed 11 years ago

dparis commented 11 years ago

Mind bumping the version on rubygems? Looks like it's out of sync with the most recent changes to master. Thanks!

machty commented 11 years ago

What in particular is out of sync? Can you be more specific?

dparis commented 11 years ago

The rubygems version is 0.1.0, updated FEB-28. Specifically, PR #5 has not been pushed to rubygems. It's causing a bundler conflict with the latest ember-rails gem version.

machty commented 11 years ago

I think it might just make more sense to change emblem-rails' dependency on ember-rails to be >= 0.11.1, since that's the last breaking API change. Any objections?

dparis commented 11 years ago

I have no objections, I'm just starting a new project and using the most recent versions of everything.

EDIT: I tend to use the semantic version arrow to constrain forward versions, maybe that would be better than '>= 0.11.1' ? It'd leave room for ember-rails updates while still (in theory) preventing a backwards incompatible change from being pulled into emblem's dependency tree.

machty commented 11 years ago

Just pushed emblem-rails 0.1.1 with relaxed dependencies on ember-rails. Let me know if you're still having issues with a bundle update

dparis commented 11 years ago

Just ran bundle update, no more version conflicts. Cheers.