search

alexsteinerde / graphql-kit

Easy setup of a GraphQL server with Vapor. It uses the GraphQL implementation of Graphiti.
MIT License
99 stars 18 forks source link

Enable middleware support #3

Closed maximkrouk closed 4 years ago

maximkrouk commented 4 years ago

Tests passed locally (macOS 10.15.4, Swift 5.2), have no idea, for now, why could they fail, changes are kinda minor 🌚

alexsteinerde commented 4 years ago

Thanks for your Pull Request. Having the register function under the RouteBuilder makes actually much more sense. You are right, the test successfully run on my machine as well. I did some experiments and I could narrow it down to Swift 5.2 introduction on Unix. On Mac everything works fine but starting with Swift 5.2 Ubuntu throws Memory issues. When I disable the --sanitize=thread flag the tests also perform perfectly under Ubuntu.