search

alexstyl / contactstore

A modern, strongly-typed contacts API for Android.
https://alexstyl.github.io/contactstore
Apache License 2.0
440 stars 15 forks source link

Provide an error-prone way to use Labels #1

Closed alexstyl closed 2 years ago

alexstyl commented 3 years ago

ContactStore expects the developer to provide an appropriate Label when they use a LabeledValue object. For example, you can represent a 'Mobile' entry as such:

val newMobile = LabeledValue(PhoneNumber("555"), PhoneNumberMobile)

and the object can be used later on in ContactStore.execute(). If the label provided is not a PhoneXYZ one, execute() will throw an exception. For example:

val newMobile = LabeledValue(PhoneNumber("555"), DateBirthday)

will compile and the LabeledValue will be created without an issue. Passing the object to execute() though will cause an exception to be thrown.

An enhancement here would be to provide developers with direct feedback of this behavior. Compilation time would be ideal but hard to maintain. Alternatively failing during Runtime when an incompatible object gets created is also an approach.

alexstyl commented 2 years ago

This is addressed in https://github.com/alexstyl/contactstore/pull/47.

From version 1.13.0 onwards, you can use any kind of Label in any LabeledValue