Refresh the sample app - Githubissues

alexstyl / contactstore

A modern, strongly-typed contacts API for Android.

https://alexstyl.github.io/contactstore

Apache License 2.0

440 stars 15 forks source link

Refresh the sample app #26

Closed tatocaster closed 2 years ago

tatocaster commented 2 years ago

updated dependencies
removed buildToolsVersion - the project automatically uses a default version of the build tools that the plugin specifies. docs
renamed compose function to follow compose naming convention
removed lint warnings - add an experimental annotation for Coil
sorted contacts in descending order by "isStarred" - to imitate the original Google contacts application
removed test runner - sample app does not have any tests

alexstyl commented 2 years ago

@tatocaster I saw you pushed some changes. Everything looks good from my end, but I am not sure if you are done with your changes. Are you happy for me to merge?

tatocaster commented 2 years ago

At this moment, yes 🚀 This PR is completely related to the sample app. I will merge it immediately when you approve

Thanks for the quick response 🙏

tatocaster commented 2 years ago

@alexstyl looks like, you need to merge those changes 🙌 I do not have the permission

alexstyl commented 2 years ago

Merged. Thanks again for the contribution @tatocaster :)