search

alexsweeten / snacc

Normalized Compression Distance for Inferring Microbial Phylogenies
8 stars 4 forks source link

Close #73 #83

Closed Benjamin-Lee closed 6 years ago

Benjamin-Lee commented 6 years ago

This PR features (improved) docstrings for all methods. runBwtDisk will require more improvement but since I didn't write, I don't feel entirely comfortable documenting it. @wilcas maybe you could add to it.

wilcas commented 6 years ago

Do you mean improvement to the docstring or refactoring code? The latter I ciuld address this weekend but the former I could do now

On Tue, Oct 23, 2018 at 23:25 Benjamin Lee notifications@github.com wrote:

This PR features (improved) docstrings for all methods. runBwtDisk will require more improvement but since I didn't write, I don't feel entirely comfortable documenting it. @wilcas https://github.com/wilcas maybe you could add to it.

You can view, comment on, or merge this pull request online at:

https://github.com/SweetiePi/snacc/pull/83 Commit Summary

  • Close #73

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SweetiePi/snacc/pull/83, or mute the thread https://github.com/notifications/unsubscribe-auth/AI5HobKruWaTRBNTagBAwMrbpclDZxeZks5uoAfdgaJpZM4X3Ng8 .

Benjamin-Lee commented 6 years ago

Improvement to the doctoring, at least for now so that I can work on better documentation. Refactoring would be also be highly appreciated!

wilcas commented 6 years ago

I'll update the docstring, I put some work into restructuring it a week ago, let me know if it's still confusing after I annotate it better