search

alexsylex / CompassNavigationOverhaul

MIT License
11 stars 7 forks source link

Compatibility with NPCs Names Distributor #26

Closed adya closed 6 months ago

adya commented 1 year ago

Hello 🙂 I was made aware of an incompatibility with NPCs Names Distributor, where CNO ignored generated names and always displayed default ones.

With this change I introduced NND API and an NPCNameProvider that will try to use that API if present, otherwise it falls back to actor->GetName() as it was before.

Please, let me know if you have any concerns with this PR.

Note: I wasn't able to test this code specifically in CNO because the CNO built from sources kept crashing on launch and I couldn't figure out why, would be great if you could help me fix the project, or check it on your side. But this PR is almost the exact copy of https://github.com/ersh1/TrueHUD/pull/4, which I tested successfully 🙂

alexsylex commented 10 months ago

Hi sorry been out for a while. Thanks this is awesome! I will add this to the repo this weekend :)

adya commented 10 months ago

Hey 😄 cool! Let me know if you have any questions/concerns.

adya commented 6 months ago

Bumping this PR 🙂 hoping that you're still around