Temp dir support - Githubissues

alexta69 / metube

Self-hosted YouTube downloader (web UI for youtube-dl / yt-dlp)

GNU Affero General Public License v3.0

4k stars 263 forks source link

Temp dir support #265

Closed breakid closed 1 year ago

breakid commented 1 year ago

Fixes #257

Added support for yt-dlp temp path
Formatted with Black
Updated README to reflect new TEMP_DIR setting; linted
Modified Dockerfile to strip carriage return characters from docker-entrypoint.sh script to fix building the image on Windows
Added example docker-compose.yml config

breakid commented 1 year ago

I've made another commit with the changes you requested.

breakid commented 1 year ago

I've reverted all formatting changes, leaving just the logic changes.

alexta69 commented 1 year ago

Hey. Thanks and sorry it took so long. I really have too little time to work on this.. I removed docker-compose.yml prior to merging as it might be confusing for users (it's building metube locally, so it's not really for users). I hope that's all right by you. Thanks again for the contribution!

breakid commented 1 year ago

I completely understand; I have the same problem! Glad I could help; thanks for merging my changes.

That's fine. I figured users would just pull the official image and anyone cloning the repo would want to build it locally (plus I had the official image in there commented out so users could switch back and forth), but it was basically straight from the README, so easy enough to reproduce.