alexta69 / metube

Self-hosted YouTube downloader (web UI for youtube-dl / yt-dlp)
GNU Affero General Public License v3.0
4k stars 263 forks source link

Clear completed/selected does not work? #275

Open gerroon opened 1 year ago

gerroon commented 1 year ago

Hi

I am trying to empty the downloaded list, so I select all in the list and click on the clear selected or clear completed but the list is never cleared up. Am I doing something wrong?

PikuZheng commented 1 year ago

osx+safari?

gerroon commented 1 year ago

I am using Chromium and Firefox on Windows.

PikuZheng commented 1 year ago

Maybe the debug console can provide more information, or your chromium version is too low (angularjs requires Chrome >= 55

gerroon commented 1 year ago

This is what I am getting in the console. My versions are all up to date like 114


ERROR TypeError: this[e].get(...) is undefined
    delById http://IP:PORT/main.2395ceb78eb7d32c.js:1
    delById http://IP:PORT/main.2395ceb78eb7d32c.js:1
    delByFilter http://IP:PORT/main.2395ceb78eb7d32c.js:1
    delSelectedDownloads http://IP:PORT/main.2395ceb78eb7d32c.js:1
    template http://IP:PORT/main.2395ceb78eb7d32c.js:1
    Of http://IP:PORT/main.2395ceb78eb7d32c.js:1
    a http://IP:PORT/main.2395ceb78eb7d32c.js:1
    Zh http://IP:PORT/main.2395ceb78eb7d32c.js:1
    invokeTask http://IP:PORT/polyfills.9883e537c98de6aa.js:1
    onInvokeTask http://IP:PORT/main.2395ceb78eb7d32c.js:1
    invokeTask http://IP:PORT/polyfills.9883e537c98de6aa.js:1
    runTask http://IP:PORT/polyfills.9883e537c98de6aa.js:1
    invokeTask http://IP:PORT/polyfills.9883e537c98de6aa.js:1
    S http://IP:PORT/polyfills.9883e537c98de6aa.js:1
    A http://IP:PORT/polyfills.9883e537c98de6aa.js:1
    L http://IP:PORT/polyfills.9883e537c98de6aa.js:1
main.2395ceb78eb7d32c.js:1:51555
    handleError http://IP:PORT/main.2395ceb78eb7d32c.js:1
    vf http://IP:PORT/main.2395ceb78eb7d32c.js:1
    Of http://IP:PORT/main.2395ceb78eb7d32c.js:1
    a http://IP:PORT/main.2395ceb78eb7d32c.js:1
    Zh http://IP:PORT/main.2395ceb78eb7d32c.js:1
    invokeTask http://IP:PORT/polyfills.9883e537c98de6aa.js:1
    onInvokeTask http://IP:PORT/main.2395ceb78eb7d32c.js:1
    invokeTask http://IP:PORT/polyfills.9883e537c98de6aa.js:1
    runTask http://IP:PORT/polyfills.9883e537c98de6aa.js:1
    invokeTask http://IP:PORT/polyfills.9883e537c98de6aa.js:1
    S http://IP:PORT/polyfills.9883e537c98de6aa.js:1
    A http://IP:PORT/polyfills.9883e537c98de6aa.js:1
    L http://IP:PORT/polyfills.9883e537c98de6aa.js:1
ERROR TypeError: this[e].get(...) is undefined
    delById http://IP:PORT/main.2395ceb78eb7d32c.js:1
    delById http://IP:PORT/main.2395ceb78eb7d32c.js:1
    delByFilter http://IP:PORT/main.2395ceb78eb7d32c.js:1
    clearCompletedDownloads http://IP:PORT/main.2395ceb78eb7d32c.js:1
    template http://IP:PORT/main.2395ceb78eb7d32c.js:1
    Of http://IP:PORT/main.2395ceb78eb7d32c.js:1
    a http://IP:PORT/main.2395ceb78eb7d32c.js:1
    Zh http://IP:PORT/main.2395ceb78eb7d32c.js:1
    invokeTask http://IP:PORT/polyfills.9883e537c98de6aa.js:1
    onInvokeTask http://IP:PORT/main.2395ceb78eb7d32c.js:1
    invokeTask http://IP:PORT/polyfills.9883e537c98de6aa.js:1
    runTask http://IP:PORT/polyfills.9883e537c98de6aa.js:1
    invokeTask http://IP:PORT/polyfills.9883e537c98de6aa.js:1
    S http://IP:PORT/polyfills.9883e537c98de6aa.js:1
    A http://IP:PORT/polyfills.9883e537c98de6aa.js:1
    L http://IP:PORT/polyfills.9883e537c98de6aa.js:1
PikuZheng commented 1 year ago

Try the browse in private mode of chrome please?

gerroon commented 1 year ago

still errors

in.2395ceb78eb7d32c.js:1 ERROR TypeError: Cannot set properties of undefined (setting 'deleting') at main.2395ceb78eb7d32c.js:1:481663 at Array.forEach () at t.delById (main.2395ceb78eb7d32c.js:1:481629) at t.delByFilter (main.2395ceb78eb7d32c.js:1:481789) at t.delSelectedDownloads (main.2395ceb78eb7d32c.js:1:554616) at main.2395ceb78eb7d32c.js:1:560841 at Of (main.2395ceb78eb7d32c.js:1:76086) at a (main.2395ceb78eb7d32c.js:1:76253) at HTMLButtonElement. (main.2395ceb78eb7d32c.js:1:162375) at _.invokeTask (polyfills.9883e537c98de6aa.js:1:9356) h

PikuZheng commented 1 year ago

sorry to hear that :(

gerroon commented 1 year ago

So is this a bug or what?

PikuZheng commented 1 year ago

It looks like you checked something, but the app can't get it. I've never had this problem using windows and chrome all the time. I had thought some plugin was blocking something, but private mode wasn't. If some firewalls between metube and windows, you may need to consider that. Or try firefox?

Nach0-Stallion commented 1 year ago

Hi, just found i'm having the same issue, went to grab a video and decided to clear up the existing ones, the clear completed does nothing, tried Chrome and firefox on Windows 11 and in private mode, same issue. no pop up blockers active on the up range, i restarted the docker and selected a few manually and clicked clear selected and they went, but trying selecting 10 and clearing seemed to bug it out and now wont clear even one, restarting the docker again didnt do anything (force updating was the same) jumped onto my iPhone. Safari, same deal im afraid happy to supply any logs or whatever maybe needed. cheers

PikuZheng commented 1 year ago

hi @Nach0-Stallion , do you use https?

gerroon commented 1 year ago

I do not use https myself, it is local lan for me.

Nach0-Stallion commented 1 year ago

hi @Nach0-Stallion , do you use https?

Hi! I access it on local lan, I deleted the 2 list files in the directory as I suspect maybe there was a file permissions issue? (Running in an Unraid docker) I have test downloaded a file and clear completed appears to be working again ☺️

gerroon commented 1 year ago

@Nach0-Stallion where is the lists fiile? I do not see anything in the "downloads" share over my docker-compose setup.

Nach0-Stallion commented 1 year ago

I believe @gerroon its in a hidden folder in the default download directory, at least mine was a .metube folder

gerroon commented 1 year ago

@Nach0-Stallion thanks, that seems to solve my issue too

zenoven commented 9 months ago

it should be a bug.

the Map is strange, some key is a string hash, some is a string of URL, when cannot get the value in the Map, it fails

image image
PikuZheng commented 9 months ago

some key is a string hash

it's the video id of youtube ( ppPd5GnNa2Y means https://www.youtube.com/watch?v=ppPd5GnNa2Y ) it will be a full url until the video id is obtained.

zenoven commented 9 months ago

some key is a string hash

it's the video id of youtube ( ppPd5GnNa2Y means https://www.youtube.com/watch?v=ppPd5GnNa2Y ) it will be a full url until the video id is obtained.

yes, but that's not the main point, I mean the value is undefined but the code wanna set deleting prop to undefined

image
zenoven commented 9 months ago

and in my case, whatever I choose(select only one item, or clear completed, etc.), the Map size is 92

image
PikuZheng commented 9 months ago

so. . . some items in the list don't have the 'format' attribute?