Fix retry button issues

alexta69 / metube

Self-hosted YouTube downloader (web UI for youtube-dl / yt-dlp)

GNU Affero General Public License v3.0

4k stars 263 forks source link

Fix retry button issues #310

Closed JLyne closed 11 months ago

JLyne commented 11 months ago

The arguments passed to retryDownload by the retry button do not match what the function actually expects. This causes a few issues:

Downloads break if a custom folder is set
Format and custom name prefix are not applied to the retried download

This PR fixes these problems by passing the entire download object to retryDownload, which now populates everything correctly. The Download interface was also updated to include all the fields actually sent by the server.

Fixes #233, #262

alexta69 commented 11 months ago

Thanks @JLyne !!

arabcoders commented 10 months ago

@JLyne Thanks for the patch i've applied it. However there seems to be an edge case where if the video failed to download due to many reason it shows weird behavior in the completed list. See attached photo.

The text in the options side seems to be the same place as the download button supposed to be.

arabcoders commented 10 months ago

Example from correct behavior for completed download vs failed download