search

alexta69 / metube

Self-hosted YouTube downloader (web UI for youtube-dl / yt-dlp)
GNU Affero General Public License v3.0
4k stars 263 forks source link

Support loading YTDL_OPTIONS from file #311

Closed arabcoders closed 10 months ago

arabcoders commented 11 months ago

This PR implements a way to load yt-dlp custom options from file using the same environment variable name, i also updated the README.md to reflect the changes.

This PR closes #210

alexta69 commented 10 months ago

@ArabCoders I reworked the PR a bit -- I was a bit concerned about trying to interpret the same env variable in two different ways (JSON and file path) so I switched to a separate env variable for specifying the file. I hope it works well for you. Thanks!

arabcoders commented 10 months ago

@ArabCoders I reworked the PR a bit -- I was a bit concerned about trying to interpret the same env variable in two different ways (JSON and file path) so I switched to a separate env variable for specifying the file. I hope it works well for you. Thanks!

Oh no worries thanks for merging the support for it. If you have a bit of time could you please take look at https://github.com/alexta69/metube/pull/310 i posted screenshot of an edge case that happens when download fail.

Thank You.