alextrv / enhanced-h264ify

A Firefox/Chrome extension that blocks video and audio codecs you have chosen on YouTube
MIT License
271 stars 17 forks source link

Loudness Normalization Option Not Working #1

Open GKid94 opened 5 years ago

GKid94 commented 5 years ago

I still have the loudness normalization when I disable the option

60550594-c91ec380-9d28-11e9-87db-c777829f0076

alextrv commented 5 years ago

The text about normalization in "Stats for nerds" isn't supposed to be changed. The extension changes volume internally. So it doesn't matter what is shown in "Stats for nerds".

GKid94 commented 5 years ago

Yes it should, it should only say 100/100 volume without the brackets like this

m0FAUdb

alextrv commented 5 years ago

The information inside parentheses is just a cosmetic thing in this case. If you worry only about that, you shouldn't. As I wrote before the extension changes volume level internally by setting it directly in video tag. If I tried to get rid of this text, the extension would depend on YouTube implementation more than it does now. So if YouTube developers made some changes in their code, there was a higher chance that disabling loudness normalization might not work. It's just more reliable solution.

GKid94 commented 5 years ago

So the extension keeps every video at 100/100 volume instead of 100/45 for example but it says in the brackets that the volume was lowered but it's not

GKid94 commented 5 years ago

I have the option enabled and it says that the volume is normalized from 9 to 5, and it sounds the same as without the extension

4535345

ogmkp commented 5 years ago

For me, I can hear a normalization difference with or without the checkbox.

GKid94 commented 5 years ago

Because the option to disable the loudness normalization is not working, you can double right click on the video and select "show controls" and when you hover the cursor over the sound icon you can see if the video volume is lowered or not

GKid94 commented 5 years ago

@alextrv @maxdrash

alextrv commented 5 years ago

Because the option to disable the loudness normalization is not working, you can double right click on the video and select "show controls" and when you hover the cursor over the sound icon you can see if the video volume is lowered or not

It does work. I've made a video to show you.

https://tinyurl.com/y43qjhs4

GKid94 commented 5 years ago

@alextrv Try it on more videos

Onurtag commented 5 years ago

It definitely works for me.
You can see the actual volume of the video in the console. With the option off it will be lower on normalized videos.
document.querySelector('video').volume

GKid94 commented 5 years ago

@Onurtag Try it on more videos

Onurtag commented 5 years ago

@GKid94 give your non-working example video?

GKid94 commented 5 years ago

@Onurtag @alextrv @maxdrash https://youtu.be/umD_6EhHlek

3425345

Onurtag commented 5 years ago

I think you are partly right.
It doesn't work if the page takes too long to load.
The correct volume might have to be continuously applied like this but I don't know how taxing requestanimationframe is or if there is a better way to do it.

I was using an userscript from the above example before I found this extension. https://gist.github.com/Onurtag/28d8826e2f7e369a3fe57bd69bb61f8f
Edit: You can use the same method if you want

alextrv commented 5 years ago

Okay, I found a bug. Steps to reproduce:

  1. Activate the option "Disable Loudness Normalization"
  2. Open a new tab and go to youtube.com
  3. Search any video and click on it
  4. Double right click on video, select "Show controls" and you will see that it doesn't work.

But if you reload the tab it should work. Probably that's because youtube uses ajax without reloading pages and it breaks the extension. I will try to fix it soon. So workaround for now: just reload the tab.

GKid94 commented 5 years ago

@alextrv Can you update the extension the option doesn't work

GKid94 commented 5 years ago

@alextrv ?

GKid94 commented 4 years ago

The option is still not working

Screenshot_7

Onurtag commented 4 years ago

@GKid94 Use the userscript https://gist.github.com/abec2304/2782f4fc47f9d010dfaab00f25e69c8a

GKid94 commented 4 years ago

How do I add it

GKid94 commented 4 years ago

?

GKid94 commented 4 years ago

@Onurtag It doesn't work

Onurtag commented 4 years ago

@GKid94 It wont show up in the UI. The audio level works correctly. We all switched to this instead btw
https://gist.github.com/abec2304/2782f4fc47f9d010dfaab00f25e69c8a

GKid94 commented 4 years ago

@Onurtag This is with that script added, the video volume is on 100%

Screenshot_1

Onurtag commented 4 years ago

Did you read the above comment? It will NOT show up in the UI.

GKid94 commented 4 years ago

@Onurtag Then how will I know if it's working or not

GKid94 commented 4 years ago

And the script also needs to be updated

Onurtag commented 4 years ago

Sorry, I didn't know you were deaf. The userscript only fixes the volume not the UI. I am unfollowing the issue. Take care and goodbye.

@alextrv Sorry for talking in here. I think you can lock this issue because we have a good alternative now.

GKid94 commented 4 years ago

@Onurtag I'm not deaf and I don't hear any difference with that scrip, and you don't have to be rude

GKid94 commented 4 years ago

@Onurtag And also the video page sometimes won't load with that script

vladaad commented 4 years ago

@GKid94 both the userscript and the extension work and I can hear the difference. It's either just you not hearing the difference, or something weird on your side.

GKid94 commented 4 years ago

@vladaad Yes they work a couple of months later after I added a scrip with Tampermonkey and YouTube changed the algorithm a little

ogmkp commented 1 year ago

This project seems abandoned.

mara004 commented 9 months ago

Indeed the normalization in enhanced-h264ify is broken or incomplete. On Linux Firefox there's a bug where loudness normalization changes the Firefox volume in the system mixer, so it's easy to tell. -- Unless there's a conflict with the "Youtube Auto HD + FPS", but I don't think so.

Is anyone aware of an up-to-date solution to get rid of this normalization?

mara004 commented 8 months ago

Whoops, seems like https://github.com/alextrv/enhanced-h264ify/issues/7 actually did the trick. See also https://gist.github.com/fa7ad/fa995474f5cb9fe91fb209686881373d?permalink_comment_id=4973229#gistcomment-4973229 ff.