search

alextseni / GreekGameDevs

MIT License
3 stars 0 forks source link

BUG - IE - object.values #3

Closed alextseni closed 6 years ago

alextseni commented 6 years ago

In internet explorer, when sorting by games in the video games database, the app crashes with error object does not support values. Explorer doesn't seem to recognize the command.

Investigate a solution (ex. rewrite the code using object.keys) for supporting explorer.

pchrysa commented 6 years ago

https://stackoverflow.com/a/42830295/1453275

pchrysa commented 6 years ago

Another solution would be to use babel polyfill in order to make new features of javascript backwards compatible. maybe this would be a better solution since other issues may occure as well

https://babeljs.io/docs/usage/polyfill/

alextseni commented 6 years ago

Looks good! Will try the polyfill solution!

alextseni commented 6 years ago

I realized that I was using lodash in the project in general so I thought of using the library for .values and .includes that didn't work on explorer instead of adding something new to the project. Hopefully, the issue was fixed and to other less popular browsers like the pre-installed browser on my phone. Long live lodash!