search

alexurquhart / vue-bootstrap-typeahead

An autocomplete/typeahead component for Vue 2 and Bootstrap 4
https://alexurquhart.github.io/vue-bootstrap-typeahead/
MIT License
206 stars 157 forks source link

keyboard navigation + auto scroll #23

Open raymondmuller opened 6 years ago

raymondmuller commented 6 years ago

Based on the pull request of @Owumaro (https://github.com/alexurquhart/vue-bootstrap-typeahead/pull/10)

Fixed the merge issues and added auto scrolling when you navigate with the arrow keys

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 40

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/VueBootstrapTypeaheadList.vue 12 30 40.0%
<!-- Total: 17 35 48.57% -->
Totals Coverage Status
Change from base Build 38: -13.0%
Covered Lines: 54
Relevant Lines: 93
💛 - Coveralls
mattzollinhofer commented 4 years ago

This PR (and a few others) is the exact reason I wanted to revive (but ended up having to fork: https://github.com/mattzollinhofer/vue-typeahead-bootstrap) this repository. I really wanted a more accessible tool to use and I saw this (and other) PRs that had already been submitted to solve the problem!

To that end, I merged in functionality that I think meets this need here: mattzollinhofer/vue-typeahead-bootstrap@6646027. This implementation is mildly different but I believe the outcome is essentially the same.

Thanks again and chime in here or on the fork if you have any other thoughts! 😄

You can find the functionality on npm here: https://www.npmjs.com/package/vue-typeahead-bootstrap.