search

alexurquhart / vue-bootstrap-typeahead

An autocomplete/typeahead component for Vue 2 and Bootstrap 4
https://alexurquhart.github.io/vue-bootstrap-typeahead/
MIT License
206 stars 157 forks source link

Added the ability to select items using arrow keys #44

Open lisandromc opened 5 years ago

lisandromc commented 5 years ago

Fixes #37 .

You may want to look at VueBootstrapTypeaheadList.vue's setActiveItem method, since it's perhaps not the cleanest solution.

fabiolima commented 5 years ago

@lisandromc your tests have failed, did you see why?

lisandromc commented 5 years ago

@lisandromc your tests have failed, did you see why?

In some contexts, $listeners.keydown will be undefined and that breaks the component. I have a fix for this, but I belatedly noticed that my PR should be done in the Development branch (duh!). I will replace this with a proper PR as soon as I have some spare time.

pvisarion commented 4 years ago

Hi! I have just installed vue-boostrap-typeahead package and I notice that keyboard navigation is still not working. Do you have any news on this? Thanks

mattzollinhofer commented 4 years ago

This is the exact reason I wanted to revive (but ended up having to fork: https://github.com/mattzollinhofer/vue-typeahead-bootstrap) this repository. I really wanted a more accessible tool to use and I saw this (and other) PRs that had already been submitted to solve the problem!

To that end, I merged in functionality that I think meets this need here: mattzollinhofer@6646027. This implementation is mildly different but I believe the outcome is essentially the same.

Thanks again and chime in here or on the fork if you have any other thoughts! 😄

You can find the functionality on npm here: https://www.npmjs.com/package/vue-typeahead-bootstrap.

pvisarion commented 4 years ago

Cool, thank you!

On Tue, Mar 3, 2020 at 1:56 PM Admire notifications@github.com wrote:

@azinamo approved this pull request.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/alexurquhart/vue-bootstrap-typeahead/pull/44?email_source=notifications&email_token=AOPEM4FW7FUNRCVWDZM3IUTRFTV7PA5CNFSM4G7SHF6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXW7U5A#pullrequestreview-367917684, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOPEM4CZFWYVGSUYJVSV7YTRFTV7PANCNFSM4G7SHF6A .