search

alexurquhart / vue-bootstrap-typeahead

An autocomplete/typeahead component for Vue 2 and Bootstrap 4
https://alexurquhart.github.io/vue-bootstrap-typeahead/
MIT License
206 stars 157 forks source link

Update scoped slot suggestion template #51

Open jhalag opened 5 years ago

jhalag commented 5 years ago

Update template example to use Vue 2.60+ syntax. See https://vuejs.org/v2/guide/components-slots.html#Scoped-Slots (cherry picked from commit a9cfc7ec4a0a7afa866bee14304890b8b26c58d1)

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 64

Totals Coverage Status
Change from base Build 38: 0.0%
Covered Lines: 47
Relevant Lines: 68
💛 - Coveralls
mattzollinhofer commented 4 years ago

I'm just plowing through the obvious problems right now to get those fixed/merged. This is a good idea, but I'll need some time to determine the impact of this change. I'm still somewhat new to Vue and don't fully understand the impacts of changes across versions.

This looks like a positive change on the surface so I'll definitely take a look at this PR again, hopefully soon.

Please do chime in if you can educate me about and dangers of conflict (or that I shouldn't be worrying about it 😄 ) either here or on the new repo: https://github.com/mattzollinhofer/vue-typeahead-bootstrap/

mattzollinhofer commented 4 years ago

This is fine, but not something I want to take on for the moment.