Added 'No results found' on emtpy matchedItems

alexurquhart / vue-bootstrap-typeahead

An autocomplete/typeahead component for Vue 2 and Bootstrap 4

https://alexurquhart.github.io/vue-bootstrap-typeahead/

MIT License

206 stars 157 forks source link

Added 'No results found' on emtpy matchedItems #55

Open wpgeek922 opened 5 years ago

wpgeek922 commented 5 years ago

Added a message for better user experience on empty results.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 69

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.388%

Totals
Change from base Build 38:	0.0%
Covered Lines:	47
Relevant Lines:	68

💛 - Coveralls

hamiltonmneto commented 4 years ago

Is there any particular reason for this PR not been merged? I'm using this component and getting complaning about not having a message on empty results

mattzollinhofer commented 4 years ago

Is there any particular reason for this PR not been merged? I'm using this component and getting complaning about not having a message on empty results

Yeah I just took a stab at this and ran into a few decisions to make that I'm not entirely sure about and ran out of time to work through. If you'd like to add some thoughts or take a stab at it you can take a look at this PR: https://github.com/mattzollinhofer/vue-typeahead-bootstrap/pull/44