search

alexusmai / vue-laravel-file-manager

Frontend for Laravel File Manager on Vue.js
MIT License
358 stars 160 forks source link

Fix modal with Bootstrap 5 #126

Open Haititi opened 2 years ago

Haititi commented 2 years ago

The <div class="fm-modal"> you are injecting is missing the bootstrap 5 class modal, so it should become: <div class="modal fm-modal">.

Can you please merge this pull request? your file-manager is not usable as it is for the moment. Please also update https://github.com/alexusmai/laravel-file-manager ! Thanks a lot!

Haititi commented 1 year ago

@alexusmai can you please merge this PR to fix your modals? None of your modals are usable without this fix. Thanks in advance.

siebsie23 commented 1 year ago

Please merge this! For me the modals are completely broken without the modal tag.

siebsie23 commented 1 year ago

Just tested, the modal is not visible when opened. You should add !important tags to the display:block and position:absolute css selectors like I did in my fork: https://github.com/siebsie23/vue-laravel-file-manager/blob/master/src/components/modals/ModalBlock.vue

alexusmai commented 1 year ago

I don’t understand why add this class, it will be overwritten by the existing one. And modal windows are displayed normally..

screen 1

screen 2

siebsie23 commented 1 year ago

For me it doesn't load the CSS variables because they are loaded with the .modal selector.

siebsie23 commented 1 year ago

@alexusmai Can I open a new PR that also adds the !important tags I mentioned which fixes my and @Haititi 's issue?