search

alexvanyo / composelife

A Game of Life simulator Android app and watchface built with Jetpack Compose
Apache License 2.0
147 stars 11 forks source link

Add settings as dialog #2218

Open alexvanyo opened 18 hours ago

alexvanyo commented 18 hours ago

Fixes #2216

https://github.com/user-attachments/assets/54b486da-d069-4257-a3ac-4ad1fb2f4b70

codecov[bot] commented 17 hours ago

Codecov Report

Attention: Patch coverage is 77.14286% with 8 lines in your changes missing coverage. Please review.

Project coverage is 60.63%. Comparing base (e218e3f) to head (aa552cc).

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...anyo/composelife/ui/app/ComposeLifeUiNavigation.kt 68.75% 2 Missing and 3 partials :warning:
...n/kotlin/com/alexvanyo/composelife/MainActivity.kt 50.00% 1 Missing and 1 partial :warning:
...com/alexvanyo/composelife/ui/app/ComposeLifeApp.kt 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2218 +/- ## ============================================ + Coverage 60.59% 60.63% +0.04% Complexity 266 266 ============================================ Files 229 229 Lines 12198 12227 +29 Branches 2316 2320 +4 ============================================ + Hits 7391 7414 +23 - Misses 3552 3555 +3 - Partials 1255 1258 +3 ``` | [Flag](https://app.codecov.io/gh/alexvanyo/composelife/pull/2218/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alex+Vanyo) | Coverage Δ | | |---|---|---| | [21](https://app.codecov.io/gh/alexvanyo/composelife/pull/2218/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alex+Vanyo) | `60.63% <77.14%> (+0.05%)` | :arrow_up: | | [35](https://app.codecov.io/gh/alexvanyo/composelife/pull/2218/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alex+Vanyo) | `?` | | | [unit](https://app.codecov.io/gh/alexvanyo/composelife/pull/2218/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alex+Vanyo) | `60.63% <77.14%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alex+Vanyo#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.