search

alexvasilkov / GestureViews

ImageView and FrameLayout with gestures control and position animation
Apache License 2.0
2.37k stars 384 forks source link

2.7.1 still has rotation offset bug #168

Closed ParticleCore closed 3 years ago

ParticleCore commented 3 years ago

I have noticed that the release version does not match the current branch version in your master. As a result, the 2.7.1 still has a bug with rotation that causes it to rotate about an incorrect center point, but this is already corrected in the master branch in the GestureController file.

The commit with the fix was pushed 2 days after 2.7.1 was released so it missed that one:

https://github.com/alexvasilkov/GestureViews/commit/f2ed7a6beb9b9e517016d4203afdac9daf96b123#diff-9b17b755bea484fcfcaba9988fd0cbacc41e74723bdfcef36bbaab86ce0d218e

alexvasilkov commented 3 years ago

But why do you think it should be part of 2.7.1? Full list of included changes can be found here: https://github.com/alexvasilkov/GestureViews/releases/tag/v2.7.1

Can you describe your issue? Are you sure it is fixed in the latest code from the repository?

ParticleCore commented 3 years ago

Rotation bug in 2.1.7

1

Rotation bug fixed in latest repository version

2

I only reverted the commit above for the file GestureController and it was sufficient to cause the problem that exists in 2.1.7

alexvasilkov commented 3 years ago

Yeah, I see, do you need the fix to be released asap?

ParticleCore commented 3 years ago

No need to hurry, fortunately this does not affect its usability, it is merely a UI inconvenience at this point for me.

ParticleCore commented 3 years ago

@alexvasilkov out of curiosity, is there any rough estimate on when the version with a fix for this is going to be released?

alexvasilkov commented 3 years ago

Version 2.8.0 is released now.

But I checked out source code and sample app for v2.7.0 and v2.7.1 and can't reproduce the issue from the gifs above. Are you sure you didn't do any extra modifications that could cause this issue? There were no major changes to GestureController in v2.7.1 or earlier (at least in the past few years), so this issue must have been there for quite a while then.