search

alexvasseur / cf_get_events

Cloud Foundry CLI plugin to report on APP, App Instance, Memory, Velocity, Service instance and Members per Org/Space & totals.
14 stars 2 forks source link

Divide by zero error in function main.Events.GetOrgsSummary line 59 #7

Closed abhinavrau closed 5 years ago

abhinavrau commented 5 years ago

Looks like the offending line 59:

orgSummary.MemoryUsage = (int)(orgSummary.Memory * 100 / orgSummary.MemoryLimitOrgQuota)

orgSummary.MemoryLimitOrgQuota is set to zero. Needs to handle the zero case.

Stacktrace:


main.Events.GetOrgsSummary(0x99c400, 0xc42014e270, 0x5)
  /Users/avasseur/s2/gitfork/src/github.com/ECSTeam/cf_get_events/search_orgsummary.go:59 +0x438
main.Events.Run(0x99c400, 0xc42014e270, 0xc420078080, 0x4, 0x4)
  /Users/avasseur/s2/gitfork/src/github.com/ECSTeam/cf_get_events/cf_bcr.go:367 +0x1916
main.(*Events).Run(0x9f2b20, 0x99c400, 0xc42014e270, 0xc420078080, 0x4, 0x4)
  <autogenerated>:1 +0x66
github.com/cloudfoundry/cli/plugin.Start(0x996340, 0x9f2b20)
  /Users/avasseur/s2/workspace-go/src/github.com/cloudfoundry/cli/plugin/plugin_shim.go:34 +0x2a0
main.main()
  /Users/avasseur/s2/gitfork/src/github.com/ECSTeam/cf_get_events/cf_bcr.go:97 +0x3d
alexvasseur commented 5 years ago

can reproduce

cf create-quota test -m 0M
cf set-quota Alex test
cf org Alex
cf bcr --ai

A quota would be having 0 or -1 or <=0 for memory when this means unlimited (assumption)

alexvasseur commented 5 years ago

release 2.2 available