search

alexvcasillas / reactron

Build Desktop Applications with React and Electron
6 stars 2 forks source link

Disable node execution for remote content #1

Closed JoeRoddy closed 6 years ago

JoeRoddy commented 6 years ago

Fix security warning.

More info: https://stackoverflow.com/questions/48854265/why-do-i-see-an-electron-security-warning-after-updating-my-electron-project-t

alexvcasillas commented 6 years ago

I'm not sure I can accept this PR 🤔 Where's the preload.js file you're referencing? Just setting the nodeIntegration: false would solve the warning that appears at development?

JoeRoddy commented 6 years ago

Yep, I pasted too quickly without looking! That prop could be used later if you need to execute node from web apis or something.

alexvcasillas commented 6 years ago

Can you post a screenshot of the current running application with this change? I'm not on a computer so I can't test this right now :)

JoeRoddy commented 6 years ago

Hah, it's not something that needs to be merged this instant. I can also only test on linux atm.

before: reactron - development_004

after: reactron - development_005

alexvcasillas commented 6 years ago

Awesome! I'm gonna merge it : )

Thanks for the PR, mate! 😉