alexvictoor / MarbleTest.Net

.NET port of RxJS marble tests
11 stars 4 forks source link

Spaces should not advance in time #11

Open GerkinDev opened 2 years ago

GerkinDev commented 2 years ago

Seeing https://github.com/alexvictoor/MarbleTest.Net/blob/master/MarbleTest.Net/Parser.cs#L85-L87, it seems that spaces ` & hyphens-` are handled the exact same way. It is not coherent with the actual behavior of RxJS marbles, where whitespaces are ignored: https://rxjs.dev/guide/testing/marble-testing#marble-syntax

I'd be glad to PR.

alexvictoor commented 2 years ago

Thanks a lot for reporting this issue. Go ahead if you would like to submit a PR!

Le dim. 5 déc. 2021 à 20:06, Gerkin @.***> a écrit :

Seeing https://github.com/alexvictoor/MarbleTest.Net/blob/master/MarbleTest.Net/Parser.cs#L85-L87, it seems that spaces & hyphens - are handled the exact same way. It is not coherent with the actual behavior of RxJS marbles, where whitespaces are ignored: https://rxjs.dev/guide/testing/marble-testing#marble-syntax

I'd be glad to PR.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/alexvictoor/MarbleTest.Net/issues/11, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADKXNCSORCKVNQDL3VKVRLUPOZ3TANCNFSM5JNDALBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.